lkml.org 
[lkml]   [2017]   [Sep]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] dmaengine: pl330: fix descriptor allocation fail
From
Date
Hello Vinod! Thanks for review!

> 26 сент. 2017 г., в 20:37, Vinod Koul <vinod.koul@intel.com> написал(а):
>
> Tested-by please...

In order to test the patch the driver should be rebuild with NR_DEFAULT_DESC defined to 1
and with some trace code included. Is it OK if I provide second patch I used for testing
with trace showing how change work?

> one more wrapper why, we dont have any logic here!
The idea was to keep rest of driver code intact. Ok, I’ll send v2 with no wrappers.

> right justifed please


Some functions has two tabs on second line, some has alignment to beginning of
argument declaration. How correct?

1) or like this (two tabs)
static int add_desc(struct list_head *pool, spinlock_t *lock,
gfp_t flg, int count)

2) Like this:
static int add_desc(struct list_head *pool, spinlock_t *lock,
gfp_t flg, int count)

Regards,
Alexander.

\
 
 \ /
  Last update: 2017-09-26 20:04    [W:0.539 / U:0.740 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site