lkml.org 
[lkml]   [2017]   [Sep]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] tools: firewire: nosy-dump: fix a resource leak in main()
On Sep 13 Martin Kepplinger wrote:
> If option_input and option_output is true two files are opened
> consecutively. In case the second fopen() fails, let's fclose()
> the first one before returning early.
>
> Signed-off-by: Martin Kepplinger <martink@posteo.de>
> ---
> tools/firewire/nosy-dump.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/tools/firewire/nosy-dump.c b/tools/firewire/nosy-dump.c
> index 3179c711bd65..228be406f206 100644
> --- a/tools/firewire/nosy-dump.c
> +++ b/tools/firewire/nosy-dump.c
> @@ -960,6 +960,8 @@ int main(int argc, const char *argv[])
> output = fopen(option_output, "w");
> if (output == NULL) {
> fprintf(stderr, "Could not open %s, %m\n", option_output);
> + if (input)
> + fclose(input);
> return -1;
> }
> }

When we return from main(), all files are closed implicitly.
--
Stefan Richter
-======----= =--= ==-=-
http://arcgraph.de/sr/

\
 
 \ /
  Last update: 2017-09-26 09:52    [W:0.032 / U:0.252 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site