lkml.org 
[lkml]   [2017]   [Sep]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 2/4] [media] usbvision-core: Use common error handling code in usbvision_set_compress_params()
From
Date
>> @@ -1913,11 +1908,12 @@ static int usbvision_set_compress_params(struct usb_usbvision *usbvision)
>> USB_DIR_OUT | USB_TYPE_VENDOR |
>> USB_RECIP_ENDPOINT, 0,
>> (__u16) USBVISION_PCM_THR1, value, 6, HZ);
>> + if (rc < 0)
>> +report_failure:
>> + dev_err(&usbvision->dev->dev,
>> + "%s: ERROR=%d. USBVISION stopped - reconnect or reload driver.\n",
>> + __func__, rc);
>
> You've been asked several times not to write code like this.

This suggestion occurred a few times.

Do you prefer to move this place to the end together with a duplicated statement “return rc;”?


> You do it later in the patch series as well.

To which update step do you refer here?

Regards,
Markus

\
 
 \ /
  Last update: 2017-09-22 16:52    [W:0.082 / U:8.460 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site