lkml.org 
[lkml]   [2017]   [Sep]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 4/4] Replace printf with fprintf for all the output functions
On Mon, Sep 18, 2017 at 01:55:22PM +0800, yuzhoujian wrote:

SNIP

> static void process_event(struct perf_script *script,
> @@ -1389,21 +1389,30 @@ static void process_event(struct perf_script *script,
> struct perf_event_attr *attr = &evsel->attr;
> unsigned int type = output_type(attr->type);
>
> + const char *evname;
> + char *file_name;
> if (output[type].fields == 0)
> return;
>
> + evname = perf_evsel__name(evsel);
> + if (script->tool.per_event_dump == true) {
> + if (asprintf(&file_name, "%s%s", evname, ".stack") < 0)

what's the 'stack' suffix for? It's text dump, should we use .txt?
Also I think it should be more than 'cycles.stack', more like:

<ORIGINAL PERF DATA FILE NAME>-script-dump-cycles.txt

or something like this

Arnaldo, thoughts?

thanks,
jirka

\
 
 \ /
  Last update: 2017-09-22 11:05    [W:0.078 / U:5.668 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site