Messages in this thread | | | Subject | Re: [PATCH v2 18/31] scsi/aic7xxx: Clean up timer usage | From | Hannes Reinecke <> | Date | Thu, 21 Sep 2017 09:35:17 +0200 |
| |
On 09/21/2017 01:27 AM, Kees Cook wrote: > stat_timer only ever assigns the same function and data, so consolidate to > a setup_timer() call and drop everything else used to pass things around. > > reset_timer is unused; remove it. > > Cc: Hannes Reinecke <hare@suse.com> > Cc: "James E.J. Bottomley" <jejb@linux.vnet.ibm.com> > Cc: "Martin K. Petersen" <martin.petersen@oracle.com> > Cc: linux-scsi@vger.kernel.org > Signed-off-by: Kees Cook <keescook@chromium.org> > --- > drivers/scsi/aic7xxx/aic79xx.h | 5 +---- > drivers/scsi/aic7xxx/aic79xx_core.c | 29 ++++++++--------------------- > 2 files changed, 9 insertions(+), 25 deletions(-) > Reviewed-by: Hannes Reinecke <hare@suse.com>
Cheers,
Hannes -- Dr. Hannes Reinecke Teamlead Storage & Networking hare@suse.com +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG Nürnberg)
| |