lkml.org 
[lkml]   [2017]   [Sep]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH net-next 01/10] net: hns3: Support for dynamically assigning tx buffer to TC
From
Date
Hi, David

On 2017/9/22 9:41, David Miller wrote:
> From: Yunsheng Lin <linyunsheng@huawei.com>
> Date: Thu, 21 Sep 2017 19:21:44 +0800
>
>> @@ -1324,23 +1324,28 @@ static int hclge_alloc_vport(struct hclge_dev *hdev)
>> return 0;
>> }
>>
>> -static int hclge_cmd_alloc_tx_buff(struct hclge_dev *hdev, u16 buf_size)
>> +static int hclge_cmd_alloc_tx_buff(struct hclge_dev *hdev)
>> {
>> /* TX buffer size is unit by 128 byte */
>> #define HCLGE_BUF_SIZE_UNIT_SHIFT 7
>> #define HCLGE_BUF_SIZE_UPDATE_EN_MSK BIT(15)
>> struct hclge_tx_buff_alloc *req;
>> + struct hclge_priv_buf *priv;
>> struct hclge_desc desc;
>> + u32 buf_size;
>> int ret;
>> u8 i;
>>
>> req = (struct hclge_tx_buff_alloc *)desc.data;
>>
>> hclge_cmd_setup_basic_desc(&desc, HCLGE_OPC_TX_BUFF_ALLOC, 0);
>> - for (i = 0; i < HCLGE_TC_NUM; i++)
>> + for (i = 0; i < HCLGE_TC_NUM; i++) {
>> + priv = &hdev->priv_buf[i];
>> + buf_size = priv->tx_buf_size;
>> req->tx_pkt_buff[i] =
>> cpu_to_le16((buf_size >> HCLGE_BUF_SIZE_UNIT_SHIFT) |

buf_size is used here

>> HCLGE_BUF_SIZE_UPDATE_EN_MSK);
>> + }
>>
>> ret = hclge_cmd_send(&hdev->hw, &desc, 1);
>> if (ret) {
>
> Local variable 'buf_size' is assigned but never used in this function.
> And with 'buf_size' removed, 'priv' also becomes unused.

>
> If it gets used in a later patch, add it in that later patch.
>
> You can also declare the variables locally in the basic block of
> the for() loop.

You are right. Will do it if there is more comment coming, thanks for
reviewing .

>
> .
>

\
 
 \ /
  Last update: 2017-09-22 03:59    [W:0.043 / U:3.824 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site