lkml.org 
[lkml]   [2017]   [Sep]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] gpio: thunderx: remove unused .map() hook from irq_domain_ops
From
Date
On 09/13/2017 07:37 PM, Masahiro Yamada wrote:
> This driver implements .alloc() hook, so .map() is not used.

Although this comment is true for this driver, it is unclear to me if
the statement is true in the general case.


>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>

Tested-by: David Daney <david.daney@cavium.com>

> ---
>
> drivers/gpio/gpio-thunderx.c | 13 -------------
> 1 file changed, 13 deletions(-)
>
> diff --git a/drivers/gpio/gpio-thunderx.c b/drivers/gpio/gpio-thunderx.c
> index 57efb25..b5adb79 100644
> --- a/drivers/gpio/gpio-thunderx.c
> +++ b/drivers/gpio/gpio-thunderx.c
> @@ -417,18 +417,6 @@ static struct irq_chip thunderx_gpio_irq_chip = {
> .flags = IRQCHIP_SET_TYPE_MASKED
> };
>
> -static int thunderx_gpio_irq_map(struct irq_domain *d, unsigned int irq,
> - irq_hw_number_t hwirq)
> -{
> - struct thunderx_gpio *txgpio = d->host_data;
> -
> - if (hwirq >= txgpio->chip.ngpio)
> - return -EINVAL;
> - if (!thunderx_gpio_is_gpio_nowarn(txgpio, hwirq))
> - return -EPERM;
> - return 0;
> -}
> -
> static int thunderx_gpio_irq_translate(struct irq_domain *d,
> struct irq_fwspec *fwspec,
> irq_hw_number_t *hwirq,
> @@ -455,7 +443,6 @@ static int thunderx_gpio_irq_alloc(struct irq_domain *d, unsigned int virq,
> }
>
> static const struct irq_domain_ops thunderx_gpio_irqd_ops = {
> - .map = thunderx_gpio_irq_map,
> .alloc = thunderx_gpio_irq_alloc,
> .translate = thunderx_gpio_irq_translate
> };
>

\
 
 \ /
  Last update: 2017-09-21 23:54    [W:0.098 / U:0.440 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site