Messages in this thread | | | From | Kalle Valo <> | Subject | Re: [PATCH] ath10: mark PM functions as __maybe_unused | Date | Thu, 21 Sep 2017 15:05:15 +0000 |
| |
Arnd Bergmann <arnd@arndb.de> writes:
> When CONFIG_PM_SLEEP is disabled, we get a compile-time > warning: > > drivers/net/wireless/ath/ath10k/pci.c:3417:12: error: 'ath10k_pci_pm_resume' defined but not used [-Werror=unused-function] > static int ath10k_pci_pm_resume(struct device *dev) > ^~~~~~~~~~~~~~~~~~~~ > drivers/net/wireless/ath/ath10k/pci.c:3401:12: error: 'ath10k_pci_pm_suspend' defined but not used [-Werror=unused-function] > static int ath10k_pci_pm_suspend(struct device *dev) > > Rather than fixing the #ifdef, this just marks both functions > as __maybe_unused, which is a more robust way to do this. > > Fixes: 32faa3f0ee50 ("ath10k: add the PCI PM core suspend/resume ops") > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Applied to ath-current branch in ath.git, thanks.
(Having problems with my patchwork script so sending this manually)
-- Kalle Valo
| |