lkml.org 
[lkml]   [2017]   [Sep]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Subject[PATCH 2/7] [media] ov2640: Improve a size determination in ov2640_probe()
    From
    Date
    From: Markus Elfring <elfring@users.sourceforge.net>
    Date: Sat, 2 Sep 2017 16:09:35 +0200

    Replace the specification of a data structure by a pointer dereference
    as the parameter for the operator "sizeof" to make the corresponding size
    determination a bit safer according to the Linux coding style convention.

    This issue was detected by using the Coccinelle software.

    Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
    ---
    drivers/media/i2c/ov2640.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/media/i2c/ov2640.c b/drivers/media/i2c/ov2640.c
    index e4ae53410097..456aa977bce8 100644
    --- a/drivers/media/i2c/ov2640.c
    +++ b/drivers/media/i2c/ov2640.c
    @@ -1097,5 +1097,5 @@ static int ov2640_probe(struct i2c_client *client,
    return -EIO;
    }

    - priv = devm_kzalloc(&client->dev, sizeof(struct ov2640_priv), GFP_KERNEL);
    + priv = devm_kzalloc(&client->dev, sizeof(*priv), GFP_KERNEL);
    if (!priv)
    --
    2.14.1
    \
     
     \ /
      Last update: 2017-09-02 17:50    [W:4.095 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site