Messages in this thread | | | Date | Wed, 20 Sep 2017 09:47:15 +0900 | From | Sergey Senozhatsky <> | Subject | Re: [PATCH 0/5] [RFC] printk/ia64/ppc64/parisc64: let's deprecate %pF/%pf printk specifiers |
| |
On (09/19/17 22:03), Helge Deller wrote: [..] > Your implementation of dereference_module_function_descriptor() in > arch/parisc/kernel/module.c is faulty. > mod->arch.fdesc_offset is relative to the base address of the module, > so you need to add to mod->core_layout.base.
aha, got it. I should have figured that out. many thanks!
> Here is the relevant patch to fix this issue (against mainline). > Additionally I compare against mod->arch.fdesc_count instead of > mod->arch.fdesc_max.
hmm, .fdesc_max looked relevant to me. it's count_fdescs() - the number of R_PARISC_FPTR64 relocation entries.
but ok, will use .fdesc_count.
> Can you please fold it into your patch > [PATCH 4/5] parisc64: Add .opd based function descriptor dereference > for the next round?
sure, will fold. + SoB.
I think I'll try to re-spin the series today (or tomorrow, I'm slightly overloaded with another stuff right now). I've received enough bug reports no need to wait for another week ;)
-ss
| |