Messages in this thread | | | Subject | Re: [PATCH net-next 1/4] net: dsa: remove copy of master ethtool_ops | From | Florian Fainelli <> | Date | Tue, 19 Sep 2017 12:55:54 -0700 |
| |
On 09/19/2017 08:56 AM, Vivien Didelot wrote: > There is no need to store a copy of the master ethtool ops, storing the > original pointer in DSA and the new one in the master netdev itself is > enough. > > In the meantime, set orig_ethtool_ops to NULL when restoring the master > ethtool ops and check the presence of the master original ethtool ops as > well as its needed functions before calling them.
I clearly like memcpy() too much, this looks good:
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com> -- Florian
| |