lkml.org 
[lkml]   [2017]   [Sep]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v2 06/10] arm64: allwinner: a64: Add devicetree binding for DMA controller
    On Sun, Sep 17, 2017 at 05:19:52AM +0200, Stefan Brüns wrote:
    > The A64 is register compatible with the H3, but has a different number
    > of dma channels and request ports.
    >
    > Attach additional properties to the node to allow future reuse of the
    > compatible for controllers with different number of channels/requests.
    >
    > If dma-requests is not specified, the register layout defined maximum
    > of 32 is used.
    >
    > Signed-off-by: Stefan Brüns <stefan.bruens@rwth-aachen.de>
    > ---
    > .../devicetree/bindings/dma/sun6i-dma.txt | 26 ++++++++++++++++++++++
    > 1 file changed, 26 insertions(+)
    >
    > diff --git a/Documentation/devicetree/bindings/dma/sun6i-dma.txt b/Documentation/devicetree/bindings/dma/sun6i-dma.txt
    > index 98fbe1a5c6dd..6ebc79f95202 100644
    > --- a/Documentation/devicetree/bindings/dma/sun6i-dma.txt
    > +++ b/Documentation/devicetree/bindings/dma/sun6i-dma.txt
    > @@ -27,6 +27,32 @@ Example:
    > #dma-cells = <1>;
    > };
    >
    > +------------------------------------------------------------------------------
    > +For A64 DMA controller:
    > +
    > +Required properties:
    > +- compatible: "allwinner,sun50i-a64-dma"
    > +- dma-channels: Number of DMA channels supported by the controller.
    > + Refer to Documentation/devicetree/bindings/dma/dma.txt
    > +- all properties above, i.e. reg, interrupts, clocks, resets and #dma-cells
    > +
    > +Optional properties:
    > +- dma-requests: Number of DMA request signals supported by the controller.
    > + Refer to Documentation/devicetree/bindings/dma/dma.txt

    You're error'ing out if dma-requests, so it isn't optional. I guess we
    should just make it mandatory.

    Once done,
    Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com>

    Maxime

    --
    Maxime Ripard, Free Electrons
    Embedded Linux and Kernel engineering
    http://free-electrons.com
    [unhandled content-type:application/pgp-signature]
    \
     
     \ /
      Last update: 2017-09-18 10:13    [W:5.196 / U:0.044 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site