[lkml]   [2017]   [Sep]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] block: move sanity checking ahead of bi_front/back_seg_size updating

On 09/19/2017 07:51 AM, Christoph Hellwig wrote:
> On Sat, Sep 16, 2017 at 07:10:30AM +0800, Jianchao Wang wrote:
>> If the bio_integrity_merge_rq() return false or nr_phys_segments exceeds
>> the max_segments, the merging fails, but the bi_front/back_seg_size may
>> have been modified. To avoid it, move the sanity checking ahead.
>> Signed-off-by: Jianchao Wang <>
> This looks fine to me:
> Reviewed-by: Christoph Hellwig <>
> But can you elaborate a little more on how this found and if there
> is a way to easily reproduce it, say for a blktests test case?
It is found when I made the patch of
'block: consider merge of segments when merge bio into rq' , not from an actual
issue or test case.


 \ /
  Last update: 2017-09-19 02:57    [W:0.061 / U:12.760 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site