[lkml]   [2017]   [Sep]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH v3 01/13] perf report: remove code to handle inline frames from browsers
On Monday, September 18, 2017 1:56:19 PM CEST Jiri Olsa wrote:
> On Wed, Sep 06, 2017 at 03:54:49PM +0200, Milian Wolff wrote:
> > The follow-up commits will make inline frames first-class citizens
> > in the callchain, thereby obsoleting all of this special code.
> so you're removing all the inline callchain implementation
> in this patch and adding it back in following patches?
> any chance you could change it gradualy? it's hard to track
> in review if you added everything that you removed ;-)

As I said before, this approach is completely different from the previous one.
There is no way to change it more gradually than what I have done. At least, I
cannot think of one.


Milian Wolff | | Senior Software Engineer
KDAB (Deutschland) GmbH&Co KG, a KDAB Group company
Tel: +49-30-521325470
KDAB - The Qt Experts[unhandled content-type:application/pkcs7-signature]
 \ /
  Last update: 2017-09-18 14:44    [W:0.042 / U:32.904 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site