lkml.org 
[lkml]   [2017]   [Sep]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.13 12/52] f2fs: let fill_super handle roll-forward errors
    Date
    4.13-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Jaegeuk Kim <jaegeuk@kernel.org>

    commit afd2b4da40b3b567ef8d8e6881479345a2312a03 upstream.

    If we set CP_ERROR_FLAG in roll-forward error, f2fs is no longer to proceed
    any IOs due to f2fs_cp_error(). But, for example, if some stale data is involved
    on roll-forward process, we're able to get -ENOENT, getting fs stuck.
    If we get any error, let fill_super set SBI_NEED_FSCK and try to recover back
    to stable point.

    Reviewed-by: Chao Yu <yuchao0@huawei.com>
    Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    fs/f2fs/recovery.c | 2 --
    1 file changed, 2 deletions(-)

    --- a/fs/f2fs/recovery.c
    +++ b/fs/f2fs/recovery.c
    @@ -599,8 +599,6 @@ out:
    }

    clear_sbi_flag(sbi, SBI_POR_DOING);
    - if (err)
    - set_ckpt_flags(sbi, CP_ERROR_FLAG);
    mutex_unlock(&sbi->cp_mutex);

    /* let's drop all the directory inodes for clean checkpoint */

    \
     
     \ /
      Last update: 2017-09-18 11:59    [W:4.008 / U:0.132 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site