Messages in this thread | | | Date | Fri, 15 Sep 2017 11:40:11 -0700 | From | Bjorn Andersson <> | Subject | Re: [PATCH v2 4/5] soc: qcom: smem: Support dynamic item limit |
| |
On Thu 14 Sep 14:25 PDT 2017, Chris Lew wrote:
> In V12 SMEM, SBL writes SMEM parameter information > after the TOC. Use the SBL provided item count > as the max item number.
Please wrap your commit messages at 72 chars (50 for the subject).
[..] > +static u32 qcom_smem_get_dynamic_item(struct qcom_smem *smem)
This naming is too similar to the functions for looking up items, please rename it to "qcom_smem_get_item_count()".
Regards, Bjorn
| |