lkml.org 
[lkml]   [2017]   [Sep]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 4/5] soc: qcom: smem: Support dynamic item limit
On Thu 14 Sep 14:25 PDT 2017, Chris Lew wrote:

> In V12 SMEM, SBL writes SMEM parameter information
> after the TOC. Use the SBL provided item count
> as the max item number.

Please wrap your commit messages at 72 chars (50 for the subject).

[..]
> +static u32 qcom_smem_get_dynamic_item(struct qcom_smem *smem)

This naming is too similar to the functions for looking up items, please
rename it to "qcom_smem_get_item_count()".

Regards,
Bjorn

\
 
 \ /
  Last update: 2017-09-15 20:40    [W:0.534 / U:0.756 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site