Messages in this thread | | | Date | Thu, 14 Sep 2017 09:57:52 +0200 | From | Johannes Thumshirn <> | Subject | Re: [Patch v2 2/2] libiscsi: Remove iscsi_destroy_session |
| |
On Wed, Sep 13, 2017 at 05:09:03PM -0700, Lee Duncan wrote: > On 07/13/2017 09:11 AM, Khazhismel Kumykov wrote: > > iscsi_session_teardown was the only user of this function. Function > > currently is just short for iscsi_remove_session + iscsi_free_session. > > > > Signed-off-by: Khazhismel Kumykov <khazhy@google.com> > > Why is this needed? I dislike changes that don't fix anything.
The function has no more users left after patch 1, so why keep it bitrotting?
-- Johannes Thumshirn Storage jthumshirn@suse.de +49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
| |