Messages in this thread | | | Date | Wed, 13 Sep 2017 19:49:17 +0300 | From | Leon Romanovsky <> | Subject | Re: [PATCH] IB/core: fix incorrect fall-through on switch statement |
| |
On Mon, Sep 11, 2017 at 05:03:13PM +0100, Colin King wrote: > From: Colin Ian King <colin.king@canonical.com> > > In the case where mbox_status is OCRDMA_MBX_STATUS_FAILED and > add_status is OCRDMA_MBX_STATUS_FAILED err_num is assigned -EAGAIN > however the case OCRDMA_MBX_STATUS_FAILED is missing a break and > falls through to the default case which then re-assigns err_num > to -EFAULT. Fix this so that err_num is assigned to -EAGAIN > for the add_status OCRDMA_MBX_STATUS_FAILED case and -EFAULT > otherwise. > > Detected by CoverityScan CID#703125 ("Missing break in switch") > > Fixes: fe2caefcdf58 ("RDMA/ocrdma: Add driver for Emulex OneConnect IBoE RDMA adapter") > Signed-off-by: Colin Ian King <colin.king@canonical.com> > --- > drivers/infiniband/hw/ocrdma/ocrdma_hw.c | 3 +++ > 1 file changed, 3 insertions(+) >
Except the wrong title: IB/core -> IB/ocrdma
Reviewed-by: Leon Romanovsky <leonro@mellanox.com> Thanks [unhandled content-type:application/pgp-signature] | |