lkml.org 
[lkml]   [2017]   [Sep]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH] ipv6: sr: Use ARRAY_SIZE macro
    From
    Date
    On Fri, 2017-09-01 at 18:35 -0700, David Miller wrote:
    > From: Thomas Meyer <thomas@m3y3r.de>
    > Date: Thu, 31 Aug 2017 16:18:15 +0200
    >
    > > Grepping for "sizeof\(.+\) / sizeof\(" found this as one of the first
    > > candidates.
    > > Maybe a coccinelle can catch all of those.

    Umm: try scripts/coccinelle/misc/array_size.cocci

    Until then, maybe a perl script?

    $ git grep --name-only sizeof.*/.*sizeof drivers/net | \
    xargs perl -p -i -e 's/\bsizeof\s*\(\s*(\w+)\s*\)\s*\/\s*sizeof\s*\(\s*\1\s*\[\s*0\s*\]\s*\)/ARRAY_SIZE(\1)/g'

    gives:

    $ git diff --stat drivers/net
     drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c                   |   2 +-
     drivers/net/ethernet/mellanox/mlx4/fw.c                         |   4 +--
     drivers/net/ethernet/mellanox/mlx4/main.c                       |   8 +++---
     drivers/net/wireless/ath/ath9k/ar9003_eeprom.c                  |   2 +-
     drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phytbl_n.c | 186 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++-----------------------------------------------------------
     5 files changed, 101 insertions(+), 101 deletions(-)

    \
     
     \ /
      Last update: 2017-09-02 05:53    [W:4.378 / U:1.132 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site