lkml.org 
[lkml]   [2017]   [Aug]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.9 26/93] ARM: dts: armada-38x: Fix irq type for pca955
    Date
    4.9-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Gregory CLEMENT <gregory.clement@free-electrons.com>

    commit 8d4514173211586c6238629b1ef1e071927735f5 upstream.

    As written in the datasheet the PCA955 can only handle low level irq and
    not edge irq.

    Without this fix the interrupt is not usable for pca955: the gpio-pca953x
    driver already set the irq type as low level which is incompatible with
    edge type, then the kernel prevents using the interrupt:

    "irq: type mismatch, failed to map hwirq-18 for
    /soc/internal-regs/gpio@18100!"

    Fixes: 928413bd859c ("ARM: mvebu: Add Armada 388 General Purpose
    Development Board support")
    Signed-off-by: Gregory CLEMENT <gregory.clement@free-electrons.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    arch/arm/boot/dts/armada-388-gp.dts | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    --- a/arch/arm/boot/dts/armada-388-gp.dts
    +++ b/arch/arm/boot/dts/armada-388-gp.dts
    @@ -75,7 +75,7 @@
    pinctrl-names = "default";
    pinctrl-0 = <&pca0_pins>;
    interrupt-parent = <&gpio0>;
    - interrupts = <18 IRQ_TYPE_EDGE_FALLING>;
    + interrupts = <18 IRQ_TYPE_LEVEL_LOW>;
    gpio-controller;
    #gpio-cells = <2>;
    interrupt-controller;
    @@ -87,7 +87,7 @@
    compatible = "nxp,pca9555";
    pinctrl-names = "default";
    interrupt-parent = <&gpio0>;
    - interrupts = <18 IRQ_TYPE_EDGE_FALLING>;
    + interrupts = <18 IRQ_TYPE_LEVEL_LOW>;
    gpio-controller;
    #gpio-cells = <2>;
    interrupt-controller;

    \
     
     \ /
      Last update: 2017-08-09 20:36    [W:4.477 / U:0.040 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site