Messages in this thread | | | From | Arnd Bergmann <> | Date | Wed, 9 Aug 2017 12:00:06 +0200 | Subject | Re: [PATCH 3/3] net: rxrpc: Replace time_t type with time64_t type |
| |
On Wed, Aug 9, 2017 at 11:33 AM, David Howells <dhowells@redhat.com> wrote: > Arnd Bergmann <arnd@arndb.de> wrote: > >> > @@ -533,8 +536,9 @@ static int rxrpc_preparse_xdr_rxk5(struct key_preparsed_payload *prep, >> > pptoken = &(*pptoken)->next) >> > continue; >> > *pptoken = token; >> > - if (token->kad->expiry < prep->expiry) >> > - prep->expiry = token->kad->expiry; >> ... >> >> I'm still slightly puzzled by what this function does: it does have four >> timestamps (authtime, starttime, endtime, renew_till) that are all >> transferred as 64-bit values and won't expire, but then it also uses the >> 32-bit expiry field in rxrpc_key_token->kad->expiry instead of the 64-bit >> rxrpc_key_token->k5 fields. > > Good catch. This is a cut'n'paste error. It should be using > token->k5->expiry here not token->kad->expiry.
Do you know which format is used in practice? Are both kad and k5 common among rxrpc users?
Arnd
| |