| Date | Tue, 8 Aug 2017 17:13:06 -0600 | From | Jason Gunthorpe <> | Subject | Re: [PATCH v06 30/36] uapi rdma/rdma_user_rxe.h: include in.h and in6.h |
| |
On Sun, Aug 06, 2017 at 06:44:21PM +0200, Mikko Rapeli wrote: > Fixes these userspace compilation errors when rdma_user_rxe.h is compiled > alone: > > rdma/rdma_user_rxe.h:59:20: error: field ???_sockaddr??? has incomplete type > struct sockaddr _sockaddr; > ^~~~~~~~~ > rdma/rdma_user_rxe.h:60:22: error: field ???_sockaddr_in??? has incomplete type > struct sockaddr_in _sockaddr_in; > ^~~~~~~~~~~~ > rdma/rdma_user_rxe.h:61:23: error: field ???_sockaddr_in6??? has incomplete type > struct sockaddr_in6 _sockaddr_in6; > ^~~~~~~~~~~~~
I'm not sure this is a good idea, linux/in.h should not be included in userspace users of this file, 'sockaddr_in' needs to come from glibc's 'netinet/in.h' instead..
Jason
|