lkml.org 
[lkml]   [2017]   [Aug]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH] thermal: fix INTEL_SOC_DTS_IOSF_CORE dependencies
    From
    Date
    On Sat, 2017-07-29 at 13:22 -0600, Pandruvada, Srinivas wrote:
    > On Fri, 2017-07-21 at 18:16 +0200, Arnd Bergmann wrote:
    > >
    > > We get a Kconfig warning when selecting this without also enabling
    > > CONFIG_PCI:
    > >
    > > warning: (X86_INTEL_LPSS && INTEL_SOC_DTS_IOSF_CORE &&
    > > SND_SST_IPC_ACPI && MMC_SDHCI_ACPI && PUNIT_ATOM_DEBUG) selects
    > > IOSF_MBI which has unmet direct dependencies (PCI)
    > >
    > > This adds a new depedency.
    > >
    > > Fixes: 3a2419f865a6 ("Thermal: Intel SoC: DTS thermal use common
    > > APIs")
    > > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
    > Reviewed-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com

    Applied.

    thanks,
    rui
    > >
    >
    > >
    > > ---
    > >  drivers/thermal/Kconfig | 4 ++--
    > >  1 file changed, 2 insertions(+), 2 deletions(-)
    > >
    > > diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig
    > > index b5b5facb8747..ac2a53823576 100644
    > > --- a/drivers/thermal/Kconfig
    > > +++ b/drivers/thermal/Kconfig
    > > @@ -342,7 +342,7 @@ config X86_PKG_TEMP_THERMAL
    > >  
    > >  config INTEL_SOC_DTS_IOSF_CORE
    > >   tristate
    > > - depends on X86
    > > + depends on X86 && PCI
    > >   select IOSF_MBI
    > >   help
    > >     This is becoming a common feature for Intel SoCs to
    > > expose
    > > the additional
    > > @@ -352,7 +352,7 @@ config INTEL_SOC_DTS_IOSF_CORE
    > >  
    > >  config INTEL_SOC_DTS_THERMAL
    > >   tristate "Intel SoCs DTS thermal driver"
    > > - depends on X86
    > > + depends on X86 && PCI
    > >   select INTEL_SOC_DTS_IOSF_CORE
    > >   select THERMAL_WRITABLE_TRIPS
    > >   help

    \
     
     \ /
      Last update: 2017-08-08 11:15    [W:6.599 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site