Messages in this thread | | | Subject | Re: [PATCH 4.4 17/91] drm: rcar-du: Simplify and fix probe error handling | From | Ben Hutchings <> | Date | Mon, 07 Aug 2017 16:17:58 +0100 |
| |
On Fri, 2017-08-04 at 16:15 -0700, Greg Kroah-Hartman wrote: [...] > @@ -291,6 +290,15 @@ static int rcar_du_probe(struct platform > rcdu->dev = &pdev->dev; > rcdu->info = of_match_device(rcar_du_of_table, rcdu->dev)->data; > > + platform_set_drvdata(pdev, rcdu); > + > + /* I/O resources */ > + mem = platform_get_resource(pdev, IORESOURCE_MEM, 0); > + rcdu->mmio = devm_ioremap_resource(&pdev->dev, mem); > + if (IS_ERR(rcdu->mmio)) > + ret = PTR_ERR(rcdu->mmio); [...]
Last line above should be:
return PTR_ERR(rcdu->mmio);
This is an error introduced in the backport, not the upstream commit.
Ben.
-- Ben Hutchings Software Developer, Codethink Ltd.
| |