lkml.org 
[lkml]   [2017]   [Aug]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH v06 12/36] x86 uapi asm/signal.h: use __kernel_size_t instead of size_t
    On Sun, Aug 6, 2017 at 6:44 PM, Mikko Rapeli <mikko.rapeli@iki.fi> wrote:
    > Fixes userspace compilation error:
    >
    > error: unknown type name ‘size_t’
    >
    > Signed-off-by: Mikko Rapeli <mikko.rapeli@iki.fi>
    > Cc: Al Viro <viro@zeniv.linux.org.uk>
    > Cc: Arnd Bergmann <arnd@arndb.de>
    > Cc: H. Peter Anvin <hpa@zytor.com>
    > ---
    > arch/x86/include/uapi/asm/signal.h | 2 +-
    > 1 file changed, 1 insertion(+), 1 deletion(-)
    >
    > diff --git a/arch/x86/include/uapi/asm/signal.h b/arch/x86/include/uapi/asm/signal.h
    > index 8264f47cf53e..74346db30758 100644
    > --- a/arch/x86/include/uapi/asm/signal.h
    > +++ b/arch/x86/include/uapi/asm/signal.h
    > @@ -127,7 +127,7 @@ struct sigaction {
    > typedef struct sigaltstack {
    > void __user *ss_sp;
    > int ss_flags;
    > - size_t ss_size;
    > + __kernel_size_t ss_size;
    > } stack_t;
    >

    In patch 14, you took a different approach based on an earlier comment
    of mine, for the same structure. I think we should definitely take the same
    approach for signal.h across all architectures, whichever we end up using.

    Arnd

    \
     
     \ /
      Last update: 2017-08-07 16:31    [W:4.164 / U:0.112 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site