Messages in this thread | | | From | Yoshihiro Shimoda <> | Subject | RE: [PATCH 3/4] phy: rcar-gen3-usb2: add SoC-specific parameter for dedicated pins | Date | Thu, 31 Aug 2017 08:35:11 +0000 |
| |
Hi Geert-san,
> From: Geert Uytterhoeven > Sent: Thursday, August 31, 2017 5:27 PM > > Hi Shimoda-san, > > On Thu, Aug 31, 2017 at 10:15 AM, Yoshihiro Shimoda > <yoshihiro.shimoda.uh@renesas.com> wrote: > >> From: Geert Uytterhoeven > >> Sent: Thursday, August 31, 2017 4:51 PM > >> On Thu, Aug 31, 2017 at 9:31 AM, Yoshihiro Shimoda > >> <yoshihiro.shimoda.uh@renesas.com> wrote: < snip > > >> Given the generic R-Car Gen3 entry sets RCAR_GEN3_PHY_HAS_DEDICATED_PINS, you > >> cannot specify the fallback compatible value of "renesas,rcar-gen3-usb2-phy" > >> in the R-Car D3 .dtsi. > > > > I understood it. > > > >> So I'm wondering, does the USB2 PHY still work (with limitations) on R-Car H3 > >> and M3-W if you drop RCAR_GEN3_PHY_HAS_DEDICATED_PINS? > > > > Yes, the USB PHY still work with limitation (otg capability channel works as > > peripheral mode only. Other channels are no limitation). > > That's good to hear. > > >> If yes, you can drop the flag from the generic entry, and R-Car D3 can specify > >> the generic fallback compatible value in its .dtsi, like H3 and M3-W. > > > > I got it. I will fix this patch set. > > And you can drop the driver change from "[PATCH 4/4] phy: rcar-gen3-usb2: add > binding for r8a77995", as it will match against the generic fallback on D3.
I got it. I will submit v2 patches soon.
Best regards, Yoshihiro Shimoda
> Thanks. > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds
| |