lkml.org 
[lkml]   [2017]   [Aug]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [RESEND PATCH 2/3] regulator: Add support for stm32-vrefbuf
From
Date


On 08/30/2017 05:02 PM, Mark Brown wrote:
> On Wed, Aug 30, 2017 at 11:11:24AM +0200, Fabrice Gasnier wrote:
>> On 08/29/2017 08:57 PM, Mark Brown wrote:
>>> On Mon, Aug 28, 2017 at 02:58:52PM +0200, Fabrice Gasnier wrote:
>
>>>> +static int __init stm32_vrefbuf_init(void)
>>>> +{
>>>> + return platform_driver_register(&stm32_vrefbuf_driver);
>>>> +}
>>>> +subsys_initcall(stm32_vrefbuf_init);
>
>>> Why is this at subsys_initcall()?
>
>> Several consumers depend on it when it's being used, among which: STM32
>> internal ADC and DAC, but also external components. Purpose is to ensure
>> it's ready before these drivers gets probed, instead of being deferred.
>> Is it ok to keep it ?
>
> No, that's not OK - just let deferred probe handle it. The same thing
> applies to all regulator usage.
>
Hi Mark,
Ok, I'll update this in v2 as well.

Thanks,
Fabrice

\
 
 \ /
  Last update: 2017-08-30 17:24    [W:0.070 / U:0.436 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site