lkml.org 
[lkml]   [2017]   [Aug]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH V1] regulator: pv88090: Exception handling for out of bounds
On Wed, Aug 30, 2017 at 05:54:27PM +0900, Eric Jeong wrote:

I've applied this but a few things to bear in mind for future
submissions:

> From: Eric Jeong <eric.jeong.opensource@diasemi.com>

Please try to ensure that your e-mail address matches the one you use
for signoff, this avoids your mail looking like a non-author send that's
missing a signoff.

> This is a patch for exception handlding that the index of array is
> out of bounds. And the definitions have been updated to use
> proper device name.

This'd be easier to review with the rename separated out from the
functional change.

> @@ -43,7 +43,7 @@ enum {
> struct pv88090_regulator {
> struct regulator_desc desc;
> /* Current limiting */
> - unsigned n_current_limits;
> + unsigned int n_current_limits;

This is fine but it's an unrelated stylistic change.
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2017-08-30 17:13    [W:0.231 / U:0.348 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site