lkml.org 
[lkml]   [2017]   [Aug]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 3/5] net: stmmac: Add Adaptrum Anarion GMAC glue layer
On Fri, Jul 28, 2017 at 03:07:03PM -0700, Alexandru Gagniuc wrote:
> Before the GMAC on the Anarion chip can be used, the PHY interface
> selection must be configured with the DWMAC block in reset.
>
> This layer covers a block containing only two registers. Although it
> is possible to model this as a reset controller and use the "resets"
> property of stmmac, it's much more intuitive to include this in the
> glue layer instead.
>
> At this time only RGMII is supported, because it is the only mode
> which has been validated hardware-wise.
>
> Signed-off-by: Alexandru Gagniuc <alex.g@adaptrum.com>
> ---
> .../devicetree/bindings/net/anarion-gmac.txt | 25 ++++

The binding looks fine, but please split to separate patch.

> drivers/net/ethernet/stmicro/stmmac/Kconfig | 9 ++
> drivers/net/ethernet/stmicro/stmmac/Makefile | 1 +
> .../net/ethernet/stmicro/stmmac/dwmac-anarion.c | 151 +++++++++++++++++++++
> 4 files changed, 186 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/net/anarion-gmac.txt
> create mode 100644 drivers/net/ethernet/stmicro/stmmac/dwmac-anarion.c

\
 
 \ /
  Last update: 2017-08-04 01:26    [W:0.245 / U:3.540 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site