lkml.org 
[lkml]   [2017]   [Aug]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 3/5] net: stmmac: Add Adaptrum Anarion GMAC glue layer
On Mon, Jul 31, 2017 at 08:11:00AM -0700, Alex wrote:
> Hi David,
>
> On 07/28/2017 07:01 PM, David Miller wrote:
> > From: Alexandru Gagniuc <alex.g@adaptrum.com>
> > Date: Fri, 28 Jul 2017 15:07:03 -0700
> >
> > > Before the GMAC on the Anarion chip can be used, the PHY interface
> > > selection must be configured with the DWMAC block in reset.
> > >
> > > This layer covers a block containing only two registers. Although it
> > > is possible to model this as a reset controller and use the "resets"
> > > property of stmmac, it's much more intuitive to include this in the
> > > glue layer instead.
> > >
> > > At this time only RGMII is supported, because it is the only mode
> > > which has been validated hardware-wise.
> > >
> > > Signed-off-by: Alexandru Gagniuc <alex.g@adaptrum.com>
> >
> > I don't see how this fits into any patch series at all. If this is
> > part of a series you posted elsewhere, you should keep netdev@ on
> > all such postings so people there can review the change in-context.
>
> I used the --cc-cmd option to send-email. I'll be sure to CC netdev@ on
> [PATCH v2].

The problem is your series spans several subsystems and it's not
clear who you intend to apply these. There aren't really any hard
dependencies between the patches, so they could all go thru different
trees. But you need to state that at least implicitly by sending the
patches TO who should apply them and CC the rest (and get_maintainers.pl
doesn't really help with that aspect). Or just don't send them in a
series if there's not an inter-dependency of the patches. Normally
bindings and a driver do go together and I'll ack the binding.

Rob

\
 
 \ /
  Last update: 2017-08-04 01:23    [W:0.068 / U:4.512 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site