lkml.org 
[lkml]   [2017]   [Aug]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] soc: versatile: remove unnecessary static in realview_soc_probe()
From
Date


On 08/02/2017 06:59 AM, Linus Walleij wrote:
> On Thu, Jul 20, 2017 at 12:40 AM, Gustavo A. R. Silva
> <gustavo@embeddedor.com> wrote:
>
>> Remove unnecessary static on local variables syscon_regmap.
>> Such variables are initialized before being used, on every
>> execution path throughout the functions. The static has no
>> benefit and, removing it reduces the object file size.
>>
>> This issue was detected using Coccinelle and the following
>> semantic patch:
>>
>> @bad exists@
>> position p;
>> identifier x;
>> type T;
>> @@
>>
>> static T x@p;
>> ...
>> x = <+...x...+>
>>
>> @@
>> identifier x;
>> expression e;
>> type T;
>> position p != bad.p;
>> @@
>>
>> -static
>> T x@p;
>> ... when != x
>> when strict
>> ?x = e;
>>
>> In the following log you can see the difference in the object file size.
>> This log is the output of the size command, before and after the code
>> change:
>>
>> before:
>> text data bss dec hex filename
>> 3339 2104 128 5571 15c3 drivers/soc/versatile/soc-realview.o
>>
>> after:
>> text data bss dec hex filename
>> 3321 2048 64 5433 1539 drivers/soc/versatile/soc-realview.o
>>
>> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
>
> Acked-by: Linus Walleij <linus.walleij@linaro.org>
>
> You probably want to funnel this patch through the ARM SoC tree.
>
> (If nothing else works, send as separate patch to arm@kernel.org)
>

OK, I'll do that. I'll add your ACK and CC you.

Thanks!
--
Gustavo A. R. Silva

\
 
 \ /
  Last update: 2017-08-04 00:08    [W:0.091 / U:1.392 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site