lkml.org 
[lkml]   [2017]   [Aug]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH 23/29] drm/tilcdc: switch to drm_*{get,put} helpers
    On Thu, Aug 3, 2017 at 3:56 PM, Jyri Sarha <jsarha@ti.com> wrote:
    >
    > Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
    >
    > On 08/03/17 14:58, Cihangir Akturk wrote:
    >> drm_*_reference() and drm_*_unreference() functions are just
    >> compatibility alias for drm_*_get() and drm_*_put() adn should not be
    >> used by new code. So convert all users of compatibility functions to use
    >> the new APIs.
    >>
    >> Signed-off-by: Cihangir Akturk <cakturk@gmail.com>
    >
    > Acked-by: Jyri Sarha <jsarha@ti.com>
    >
    > This appears to be a part of a larger series. So I guess it will go in
    > via drm-misc. But if this is not the case just let me know and I'll add
    > this to my next pull request.

    Only if you join drm-misc and push it there yourself :-)

    In general I prefer driver maintainers pick up their stuff for patch
    series which don't have depencies like this here, otherwise, why
    exactly do we have driver maintainers.

    Thanks, Daniel

    >
    > Best Regards,
    > Jyri
    >
    >> ---
    >> drivers/gpu/drm/tilcdc/tilcdc_crtc.c | 6 +++---
    >> 1 file changed, 3 insertions(+), 3 deletions(-)
    >>
    >> diff --git a/drivers/gpu/drm/tilcdc/tilcdc_crtc.c b/drivers/gpu/drm/tilcdc/tilcdc_crtc.c
    >> index d524ed0..6e936dd 100644
    >> --- a/drivers/gpu/drm/tilcdc/tilcdc_crtc.c
    >> +++ b/drivers/gpu/drm/tilcdc/tilcdc_crtc.c
    >> @@ -75,7 +75,7 @@ static void unref_worker(struct drm_flip_work *work, void *val)
    >> struct drm_device *dev = tilcdc_crtc->base.dev;
    >>
    >> mutex_lock(&dev->mode_config.mutex);
    >> - drm_framebuffer_unreference(val);
    >> + drm_framebuffer_put(val);
    >> mutex_unlock(&dev->mode_config.mutex);
    >> }
    >>
    >> @@ -456,7 +456,7 @@ static void tilcdc_crtc_set_mode(struct drm_crtc *crtc)
    >>
    >> set_scanout(crtc, fb);
    >>
    >> - drm_framebuffer_reference(fb);
    >> + drm_framebuffer_get(fb);
    >>
    >> crtc->hwmode = crtc->state->adjusted_mode;
    >> }
    >> @@ -621,7 +621,7 @@ int tilcdc_crtc_update_fb(struct drm_crtc *crtc,
    >> return -EBUSY;
    >> }
    >>
    >> - drm_framebuffer_reference(fb);
    >> + drm_framebuffer_get(fb);
    >>
    >> crtc->primary->fb = fb;
    >> tilcdc_crtc->event = event;
    >>
    >
    >
    > _______________________________________________
    > dri-devel mailing list
    > dri-devel@lists.freedesktop.org
    > https://lists.freedesktop.org/mailman/listinfo/dri-devel



    --
    Daniel Vetter
    Software Engineer, Intel Corporation
    +41 (0) 79 365 57 48 - http://blog.ffwll.ch

    \
     
     \ /
      Last update: 2017-08-03 17:43    [W:3.035 / U:0.216 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site