lkml.org 
[lkml]   [2017]   [Aug]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/9] ASoC: max98927: Added support for DSP_A and DSP_B format
On Mon, Aug 28, 2017 at 04:30:53PM -0700, Ryan Lee wrote:

> + if ((max98927->iface == SND_SOC_DAIFMT_DSP_A) ||
> + (max98927->iface == SND_SOC_DAIFMT_DSP_B))
> + return 0;
> +
> + /* BCLK configuration */

Why do we not configure the BCLK in DSP modes? That's unusual and seems
likely to break some systems that rely on exact clocking.

Also if we're selecting on format a switch statement is generally better
to make any further special casing easier in future.
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2017-08-29 21:24    [W:0.396 / U:0.124 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site