lkml.org 
[lkml]   [2017]   [Aug]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v2 14/20] mm: Provide speculative fault infrastructure
    On Tue, Aug 29, 2017 at 09:59:30AM +0200, Laurent Dufour wrote:
    > On 27/08/2017 02:18, Kirill A. Shutemov wrote:
    > >> +
    > >> + if (unlikely(!vma->anon_vma))
    > >> + goto unlock;
    > >
    > > It deserves a comment.
    >
    > You're right I'll add it in the next version.
    > For the record, the root cause is that __anon_vma_prepare() requires the
    > mmap_sem to be held because vm_next and vm_prev must be safe.

    But should that test not be:

    if (unlikely(vma_is_anonymous(vma) && !vma->anon_vma))
    goto unlock;

    Because !anon vmas will never have ->anon_vma set and you don't want to
    exclude those.

    \
     
     \ /
      Last update: 2017-08-29 14:05    [W:4.241 / U:0.200 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site