lkml.org 
[lkml]   [2017]   [Aug]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] x86/debug: Handle warnings before the notifier chain
Date
Peter Zijlstra <peterz@infradead.org> writes:

> On Mon, Jul 24, 2017 at 01:04:28PM +0300, Alexander Shishkin wrote:
>> Commit
>>
>> 9a93848fe787 ("x86/debug: Implement __WARN() using UD0")
>>
>> turned warnings into UD0, but the fixup code only runs after the
>> notify_die() chain. This is a problem, in particular, with kgdb,
>> which kicks in as if it was a BUG().
>>
>> Fix this by running the fixup code before the notifier chain in
>> the invalid op handler path.
>
> So arguable it might be nice to have kgdb trap on a WARN, but it
> treating it as a BUG is obviously undesirable.
>
> Jason, what would you want kgdb to do here?

Ping.

\
 
 \ /
  Last update: 2017-08-29 13:54    [W:0.051 / U:0.704 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site