lkml.org 
[lkml]   [2017]   [Aug]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v5 1/2] sched/clock: interface to allow timestamps early in boot
From
Date
>> void __init timekeeping_init(void)
>> {
>> /*
>> * We must determine boot timestamp before getting current
>> * persistent clock value, because implementation of
>> * read_boot_clock64() might also call the persistent
>> * clock, and a leap second may occur.
>> */
>>
>> read_boot_clock64(&boot);
>> ...
>> read_persistent_clock64(&now);
>
> No. That's the same crap just the other way round.
>
> s390 can do that, because the boot timestamp is correlated with the
> persistent clock. Your's not so much.
>

OK, how about reading the persistent clock only once, and send it's
value to use for calculation of boot stamp to read_boot_clock64() via a
new argument:

read_boot_clock64(&now, &boot);

Does this sound alright or is there a better way?

I would need to update read_boot_clock64() everywhere it is declared to
add the __init macro, so this extra argument is not going to increase
number of line changes.

Thank you,
Pasha

\
 
 \ /
  Last update: 2017-08-28 20:01    [W:0.147 / U:0.016 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site