Messages in this thread | | | From | KY Srinivasan <> | Subject | RE: [PATCHv2] hv_set_ifconfig.sh double check before setting ip | Date | Mon, 28 Aug 2017 16:48:32 +0000 |
| |
> -----Original Message----- > From: Haiyang Zhang > Sent: Monday, August 28, 2017 8:57 AM > To: Stephen Hemminger <stephen@networkplumber.org>; Eduardo Otubo > <otubo@redhat.com>; KY Srinivasan <kys@microsoft.com> > Cc: linux-kernel@vger.kernel.org; devel@linuxdriverproject.org; Stephen > Hemminger <sthemmin@microsoft.com>; David Miller > <davem@davemloft.net> > Subject: RE: [PATCHv2] hv_set_ifconfig.sh double check before setting ip > > > > > -----Original Message----- > > From: Stephen Hemminger [mailto:stephen@networkplumber.org] > > Sent: Monday, August 28, 2017 11:16 AM > > To: Eduardo Otubo <otubo@redhat.com> > > Cc: linux-kernel@vger.kernel.org; devel@linuxdriverproject.org; Haiyang > > Zhang <haiyangz@microsoft.com>; Stephen Hemminger > > <sthemmin@microsoft.com>; David Miller <davem@davemloft.net> > > Subject: Re: [PATCHv2] hv_set_ifconfig.sh double check before setting ip > > > > On Mon, 28 Aug 2017 12:01:21 +0200 > > Eduardo Otubo <otubo@redhat.com> wrote: > > > > > v2: The script is now a little bit safer so it doesn't conflicts with > > > network daemon trying to set configurations at the same time. > > > > > > This patch fixes the behavior of the hv_set_ifconfig script when > > setting > > > the interface ip. Sometimes the interface has already been configured > > by > > > network daemon, in this case hv_set_ifconfig causes "RTNETLINK: file > > > exists error"; in order to avoid this error this patch makes sure > > double > > > checks the interface before trying anything. > > > > > > Signed-off-by: Eduardo Otubo <otubo@redhat.com> > > > > Adding new dependency on systemd is not going to make this script > > even less useful. I wonder why the script still exists at all? Most of > > the > > Linux distro's can already setup HV networking without it. > > > > This script is used by a host to inject IP into guests. KY knows more > details about it.
I wrote this script initially to provide an example script for Distros to base their solution on. KVP supports IP injection to enable VM migration. For this scenario, I think we recommend that NM be disabled.
K. Y >
| |