Messages in this thread | | | Date | Mon, 28 Aug 2017 09:19:06 +0300 | From | Dan Carpenter <> | Subject | Re: [PATCH] staging: rtl8723bs: remove memset before memcpy |
| |
On Mon, Aug 28, 2017 at 01:43:31AM +0530, Himanshu Jha wrote: > calling memcpy immediately after memset with the same region of memory > makes memset redundant. > > Build successfully. >
Thanks for the patch, it looks good. You don't need to say that it builds successfully, because we already assume that's true.
> Signed-off-by: Himanshu Jha <himanshujha199640@gmail.com> > ---
Sometimes I put a comment here under the cut off line if I want people to know that I haven't tested a patch.
Anyway, don't resend the patch. It's fine as-is (unless Greg complains) but it's just for future reference.
regards, dan carpenter
| |