lkml.org 
[lkml]   [2017]   [Aug]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[tip:efi/core] efi/reboot: Make function pointer orig_pm_power_off static
    Commit-ID:  68ee51cb773bed81f9ff7144eca0a08550e1f9a1
    Gitweb: http://git.kernel.org/tip/68ee51cb773bed81f9ff7144eca0a08550e1f9a1
    Author: Colin Ian King <colin.king@canonical.com>
    AuthorDate: Fri, 25 Aug 2017 16:50:17 +0100
    Committer: Ingo Molnar <mingo@kernel.org>
    CommitDate: Sat, 26 Aug 2017 09:20:33 +0200

    efi/reboot: Make function pointer orig_pm_power_off static

    The function pointer orig_pm_power_off is local to the source and does
    not need to be in global scope, so make it static.

    Cleans up sparse warning:
    symbol 'orig_pm_power_off' was not declared. Should it be static?

    Signed-off-by: Colin Ian King <colin.king@canonical.com>
    Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
    Cc: Linus Torvalds <torvalds@linux-foundation.org>
    Cc: Matt Fleming <matt@codeblueprint.co.uk>
    Cc: Peter Zijlstra <peterz@infradead.org>
    Cc: Thomas Gleixner <tglx@linutronix.de>
    Cc: linux-efi@vger.kernel.org
    Link: http://lkml.kernel.org/r/20170825155019.6740-4-ard.biesheuvel@linaro.org
    Signed-off-by: Ingo Molnar <mingo@kernel.org>
    ---
    drivers/firmware/efi/reboot.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/firmware/efi/reboot.c b/drivers/firmware/efi/reboot.c
    index 7117e2d..2287454 100644
    --- a/drivers/firmware/efi/reboot.c
    +++ b/drivers/firmware/efi/reboot.c
    @@ -5,7 +5,7 @@
    #include <linux/efi.h>
    #include <linux/reboot.h>

    -void (*orig_pm_power_off)(void);
    +static void (*orig_pm_power_off)(void);

    int efi_reboot_quirk_mode = -1;

    \
     
     \ /
      Last update: 2017-08-26 10:04    [W:2.779 / U:0.372 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site