lkml.org 
[lkml]   [2017]   [Aug]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCHi v2] arc: Mask individual IRQ lines during core INTC init
Date
Hi Vineet,

On Fri, 2017-08-25 at 10:13 -0700, Vineet Gupta wrote:
> On 08/25/2017 07:22 AM, Alexey Brodkin wrote:
> >
> > From: Alexey Brodkin <Alexey.Brodkin@synopsys.com>
> >
> > ARC cores on reset have all interrupt lines of built-in INTC enabled.
> > Which means once we globally enable interrupts (very early on boot)
> > faulty hardware blocks may trigger an interrupt that Linux kernel
> > cannot handle yet as corresponding handler is not yet installed.
> >
> > In that case system falls in "interrupt storm" and basically never
> > does anything useful except entering and exiting generic IRQ handling
> > code.
> >
> > One real example of that kind of problematic hardware is DW GMAC which
> > also has interrupts enabled on reset and if Ethernet PHY informs GMAC
> > about link state, GMAC immediately reports that upstream to ARC core
> > and here we are.
> >
> > Now with that change we mask all individual IRQ lines making entire
> > system more fool-proof.
> >
> > [This patch was motivated by Adaptrum platform support]
> >
> > Signed-off-by: Alexey Brodkin <abrodkin@synopsys.com>
> > Cc: Eugeniy Paltsev <paltsev@synopsys.com>
> > Tested-by: Alexandru Gagniuc <alex.g@adaptrum.com>
> > Signed-off-by: Vineet Gupta <vgupta@synopsys.com>
>
> v1 was merged in mainline this week - please provide a fixup patch on top of 
> mainline / for-curr !

Ooops, didn't see that.
Will do shortly.

-Alexey
\
 
 \ /
  Last update: 2017-08-25 19:23    [W:0.056 / U:1.992 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site