Messages in this thread | | | From | Linus Torvalds <> | Date | Thu, 24 Aug 2017 11:31:40 -0700 | Subject | Re: [PATCH 0/1] devpts: use dynamic_dname() to generate proc name |
| |
On Thu, Aug 24, 2017 at 11:13 AM, Linus Torvalds <torvalds@linux-foundation.org> wrote: > > The attached patch should work. It's Eric's original patch with > various cleanups and fixes.
No, one more bug in there: Eric did
+ case TIOCGPTPEER: + retval = ptm_open_peer(file, tty, (int)arg); + break;
to call that ptm_open_peer(), but that's bogus. The "break;" will just cause it to continue with the tty ioctl handling, and result in -ENOTTY in the end.
So it actually *did* open the slave, but then threw the returned fd value away.
It should just do a "return ptm_open_peer(file, tty, (int)arg);" instead.
Linus
| |