lkml.org 
[lkml]   [2017]   [Aug]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3] staging: olpc_dcon: remove pointless debug printk in dcon_freeze_store()
On Thu, Aug 24, 2017 at 02:10:37PM +0800, Shurong Zhang wrote:
> This printk doesn't really add anything worthwhile.
>
> Signed-off-by: Shurong Zhang <zhang_shurong@foxmail.com>
> ---
> drivers/staging/olpc_dcon/olpc_dcon.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/staging/olpc_dcon/olpc_dcon.c b/drivers/staging/olpc_dcon/olpc_dcon.c
> index f7f3a78..f9d9465 100644
> --- a/drivers/staging/olpc_dcon/olpc_dcon.c
> +++ b/drivers/staging/olpc_dcon/olpc_dcon.c
> @@ -456,7 +456,6 @@ static ssize_t dcon_freeze_store(struct device *dev,
> if (ret)
> return ret;
>
> - pr_info("dcon_freeze_store: %lu\n", output);
>

Delete a blank line as well. We don't allow two blank lines in a row.

regards,
dan carpenter

\
 
 \ /
  Last update: 2017-08-24 16:08    [W:0.028 / U:0.044 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site