lkml.org 
[lkml]   [2017]   [Aug]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH net-next 02/13] phy: add the mvebu cp110 comphy driver
    > +	for_each_available_child_of_node(pdev->dev.of_node, child) {
    > + struct mvebu_comphy_lane *lane;
    > + struct phy *phy;
    > + int ret;
    > + u32 val;
    > +
    > + ret = of_property_read_u32(child, "reg", &val);
    > + if (ret < 0) {
    > + dev_err(&pdev->dev, "missing 'reg' property (%d)\n",
    > + ret);
    > + continue;
    > + }

    I'm just wondering why we need this. We know how many lanes there are
    from the table. So just create a generic PHY for each lane?

    Andrew

    \
     
     \ /
      Last update: 2017-08-24 15:45    [W:3.253 / U:0.340 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site