[lkml]   [2017]   [Aug]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
Patch in this message
Subject[PATCH 2/2] x86: entry, use ENTRY instead of ALIGN+GLOBAL for stub32_clone
ALIGN+GLOBAL is effectively what ENTRY does, so use ENTRY which is
dedicated for exactly this purpose -- global functions.

Note that stub32_clone is a C-like leaf function -- it has a standard
call frame -- it only switches one argument and continues by jumping
into C. And since each ENTRY should be balanced by some END*, we add a
corresponding ENDPROC to stub32_clone too.

Besides that, x86's custom GLOBAL macro is going to die very soon.

Signed-off-by: Jiri Slaby <>
Cc: "H. Peter Anvin" <>
Cc: Thomas Gleixner <>
Cc: Ingo Molnar <>
Cc: <>
arch/x86/entry/entry_64_compat.S | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/x86/entry/entry_64_compat.S b/arch/x86/entry/entry_64_compat.S
index d8468ba24be0..e26c25ca7756 100644
--- a/arch/x86/entry/entry_64_compat.S
+++ b/arch/x86/entry/entry_64_compat.S
@@ -340,8 +340,7 @@ ENTRY(entry_INT80_compat)
jmp restore_regs_and_iret

* The 32-bit clone ABI is: clone(..., int tls_val, int *child_tidptr).
* The 64-bit clone ABI is: clone(..., int *child_tidptr, int tls_val).
@@ -351,3 +350,4 @@ GLOBAL(stub32_clone)
xchg %r8, %rcx
jmp sys_clone
 \ /
  Last update: 2017-08-24 10:10    [W:0.049 / U:1.528 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site