lkml.org 
[lkml]   [2017]   [Aug]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 3/3] ARM: dts: sun8i: Add board dts file for Banana Pi M2 Berry
On Wed, Aug 23, 2017 at 01:46:50PM +0800, Icenowy Zheng wrote:
>
>
> 于 2017年8月23日 GMT+08:00 上午4:12:15, Maxime Ripard <maxime.ripard@free-electrons.com> 写到:
> >On Tue, Aug 22, 2017 at 02:17:42PM +0800, Icenowy Zheng wrote:
> >> +&reg_vcc5v0 {
> >> + gpio = <&pio 7 23 GPIO_ACTIVE_HIGH>; /* PH23 */
> >> + enable-active-high;
> >> +};
> >
> >Same thing here, you're not using that regulator anywhere. You don't
> >even use any of the regulators in sunxi-common-regulators.
>
> Maybe I should drop the regulator now, and re-introduce it when adding USB/SATA?

If that's what it's used for, then yes, please.

Maxime

--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2017-08-23 16:32    [W:0.058 / U:0.240 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site