Messages in this thread | | | From | Linus Walleij <> | Date | Wed, 23 Aug 2017 10:29:23 +0200 | Subject | Re: [PATCH v9 1/2] serio: PS/2 gpio bit banging driver for serio bus |
| |
On Mon, Aug 21, 2017 at 9:31 PM, Danilo Krummrich <danilokrummrich@dk-develop.de> wrote:
> +static int __ps2_gpio_write(struct serio *serio, unsigned char val) > +static int ps2_gpio_write(struct serio *serio, unsigned char val)
I never like the random use of __prefixes as they have unclear semantics.
I would name it something concise.
Anyways, that is up to the subsystem maintainer. From a GPIO point of view: Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Yours, Linus Walleij
| |