lkml.org 
[lkml]   [2017]   [Aug]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] drivers: staging: rtl8192e: make const qualified argument
On Tue, Aug 22, 2017 at 09:01:02PM +0530, Himanshu Jha wrote:
> The ether_addr_copy expects const u8* as its second argument, therefore
> pass const qualified argument instead of non-const argument.

Huh, why?

>
> Signed-off-by: Himanshu Jha <himanshujha199640@gmail.com>
> ---
> drivers/staging/rtl8192e/rtl819x_BAProc.c | 13 ++++++-------
> 1 file changed, 6 insertions(+), 7 deletions(-)

Always use scripts/get_maintainer.pl on your patch to know who to send
it to, and what lists as well.

>
> diff --git a/drivers/staging/rtl8192e/rtl819x_BAProc.c b/drivers/staging/rtl8192e/rtl819x_BAProc.c
> index 1720e1b..f34a4ee 100644
> --- a/drivers/staging/rtl8192e/rtl819x_BAProc.c
> +++ b/drivers/staging/rtl8192e/rtl819x_BAProc.c
> @@ -97,10 +97,9 @@ static struct sk_buff *rtllib_ADDBA(struct rtllib_device *ieee, u8 *Dst,
>
> BAReq = skb_put(skb, sizeof(struct rtllib_hdr_3addr));
>
> - ether_addr_copy(BAReq->addr1, Dst);
> - ether_addr_copy(BAReq->addr2, ieee->dev->dev_addr);
> -
> - ether_addr_copy(BAReq->addr3, ieee->current_network.bssid);
> + ether_addr_copy(BAReq->addr1, (const u8 *)Dst);
> + ether_addr_copy(BAReq->addr2, (const u8 *)ieee->dev->dev_addr);
> + ether_addr_copy(BAReq->addr3, (const u8 *)ieee->current_network.bssid);

I don't understand what this patch "solves"...

thanks,

greg k-h

\
 
 \ /
  Last update: 2017-08-23 03:36    [W:0.056 / U:9.168 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site