lkml.org 
[lkml]   [2017]   [Aug]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH net-next] net: phy: Deal with unbound PHY driver in phy_attached_print()
From
From: Florian Fainelli <f.fainelli@gmail.com>
Date: Tue, 22 Aug 2017 14:45:44 -0700

> On 08/22/2017 02:44 PM, David Miller wrote:
>> From: Florian Fainelli <f.fainelli@gmail.com>
>> Date: Tue, 22 Aug 2017 14:26:47 -0700
>>
>>> Priit reported that stmmac was crashing with the trace below. This is because
>>> phy_attached_print() is called too early right after the PHY device has been
>>> found, but before it has a driver attached, since that is only done in
>>> phy_probe() which occurs later.
>>>
>>> Fix this by dealing with a possibly NULL phydev->drv point since that can
>>> happen here, but could also happen if we voluntarily did an unbind of the
>>> PHY device with the PHY driver.
>> ...
>>> Tested-By: Priit Laes <plaes@plaes.org>
>>> Fixes: fbca164776e4 ("net: stmmac: Use the right logging function in stmmac_mdio_register")
>>> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
>>
>> "net-next"? The commit which introduced this problem is in 'net', don't we want
>> to fix it there?
>
> Oh yes we do, somehow I thought the commit was just in "net-next" hence
> the subject, the patch applies cleanly to "net" as well.

I thought so, thanks for clarifying.

Applied.

\
 
 \ /
  Last update: 2017-08-22 23:50    [W:0.031 / U:4.508 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site