lkml.org 
[lkml]   [2017]   [Aug]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2] mfd: max77693: Add muic of_compatible in mfd_cell
On 2017년 08월 22일 16:14, Chanwoo Choi wrote:
> Hi,
>
> On 2017년 08월 22일 16:09, Maciej Purski wrote:
>> This patch adds muic of_compatible in order to use the muic device
>> driver in device tree.
>>
>> v2:
>> - added muic to documentation
>>
>> Signed-off-by: Maciej Purski <m.purski@samsung.com>
>> ---
>> Documentation/devicetree/bindings/mfd/max77693.txt | 6 ++++++
>> drivers/mfd/max77693.c | 5 ++++-
>> 2 files changed, 10 insertions(+), 1 deletion(-)
>>
>> diff --git a/Documentation/devicetree/bindings/mfd/max77693.txt b/Documentation/devicetree/bindings/mfd/max77693.txt
>> index 6a1ae3a..6ca2478 100644
>> --- a/Documentation/devicetree/bindings/mfd/max77693.txt
>> +++ b/Documentation/devicetree/bindings/mfd/max77693.txt
>> @@ -127,6 +127,12 @@ Required properties for the LED child node:
>> Optional properties for the LED child node:
>> - label : see Documentation/devicetree/bindings/leds/common.txt
>>
>> +Optional nodes:
>> +- max77693-muic/max77693-muic :

Also, max77693-muic is duplicate.

>> + Node used only by extcon consumers.
>> + Required properties:
>> + - compatible : "maxim,max77693-muic" or "maxim,max77693-muic"
>
> "maxim,max77693-muic" is duplicate. Please add just one compatible.
>
>> +
>> Example:
>> #include <dt-bindings/leds/common.h>
>>
>> diff --git a/drivers/mfd/max77693.c b/drivers/mfd/max77693.c
>> index 662ae0d..1c05ea0 100644
>> --- a/drivers/mfd/max77693.c
>> +++ b/drivers/mfd/max77693.c
>> @@ -48,7 +48,10 @@ static const struct mfd_cell max77693_devs[] = {
>> .name = "max77693-charger",
>> .of_compatible = "maxim,max77693-charger",
>> },
>> - { .name = "max77693-muic", },
>> + {
>> + .name = "max77693-muic",
>> + .of_compatible = "maxim,max77693-muic",
>> + },
>> {
>> .name = "max77693-haptic",
>> .of_compatible = "maxim,max77693-haptic",
>>
>
>


--
Best Regards,
Chanwoo Choi
Samsung Electronics

\
 
 \ /
  Last update: 2017-08-22 09:16    [W:0.039 / U:18.980 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site