lkml.org 
[lkml]   [2017]   [Aug]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/3] ARM: dts: sun7i: Fix A20-OLinuXino-MICRO dts for use with LAN8710
On Tue, Aug 22, 2017 at 02:43:11PM +0300, Stefan Mavrodiev wrote:
> From revision J the board uses new phy chip LAN8710. Compared
> with RTL8201, RA17 pin is TXERR. It has pullup which causes phy
> not to work. To fix this, PA17 must be configured output-low.
>
> This patch is compatible with earlier board revisions, since this
> pin wasn't connected to phy.
>
> Signed-off-by: Stefan Mavrodiev <stefan@olimex.com>
>
> ---
> arch/arm/boot/dts/sun7i-a20-olinuxino-micro.dts | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/sun7i-a20-olinuxino-micro.dts b/arch/arm/boot/dts/sun7i-a20-olinuxino-micro.dts
> index 0b7403e4d687..578c761b551a 100644
> --- a/arch/arm/boot/dts/sun7i-a20-olinuxino-micro.dts
> +++ b/arch/arm/boot/dts/sun7i-a20-olinuxino-micro.dts
> @@ -102,7 +102,7 @@
>
> &gmac {
> pinctrl-names = "default";
> - pinctrl-0 = <&gmac_pins_mii_a>;
> + pinctrl-0 = <&gmac_pins_mii_a>,<&gmac_txerr_pin>;
> phy = <&phy1>;
> phy-mode = "mii";
> status = "okay";
> @@ -229,6 +229,11 @@
> };
>
> &pio {
> + gmac_txerr_pin: gmac_txerr_pin@0 {
> + pins = "PA17";
> + function = "gpio_out"
> + };
> +

You're not enforcing any level doing this. If you're using that pin as
TXERR, why not mux it to the gmac function and let the GMAC control it?

Maxime

--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2017-08-22 22:33    [W:0.075 / U:12.276 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site